Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a colorscale when scatter3d.line.showscale is set #3384

Merged
merged 6 commits into from Jan 14, 2019

Conversation

Projects
None yet
2 participants
@archmoj
Copy link
Collaborator

archmoj commented Jan 2, 2019

@@ -14,7 +14,11 @@ Scatter3D.plot = require('./convert');
Scatter3D.attributes = require('./attributes');
Scatter3D.markerSymbols = require('../../constants/gl3d_markers');
Scatter3D.supplyDefaults = require('./defaults');
Scatter3D.colorbar = require('../scatter/marker_colorbar');
Scatter3D.colorbar = {
container: 'marker | line',

This comment has been minimized.

Copy link
@etpinard

etpinard Jan 2, 2019

Member

Hmm. That | business is a little too hacky for my taste.

Could you make this:

 Scatter3D.colorbar = [{
  container: 'marker',
  min: 'cmin',
  max: 'cmax'
}, {
  container: 'line',
  min: 'cmin',
  max: 'cmax'
}]

? Thank you!

@@ -41,19 +41,28 @@ module.exports = function connectColorbar(gd, cd, moduleOpts) {

var trace = cd[0].trace;
var cbId = 'cb' + trace.uid;
var containerName = moduleOpts.container;
var container = containerName ? trace[containerName] : trace;
var containerNames = (moduleOpts.container) ?

This comment has been minimized.

Copy link
@etpinard

etpinard Jan 2, 2019

Member

.... and let's make this Array.isArray(moduleOpts.container) ? ....

@etpinard

This comment has been minimized.

Copy link
Member

etpinard commented Jan 2, 2019

Thanks for taking this one! A fairly easy new feature ripe for v1.44.0.

Could you make sure to add a test mock?

@etpinard etpinard added this to the 1.44.0 milestone Jan 2, 2019

archmoj added some commits Jan 3, 2019

@etpinard

This comment has been minimized.

Copy link
Member

etpinard commented Jan 14, 2019

💃 - let's start merging things for 1.44.0

Nice work @archmoj !

@archmoj archmoj merged commit c2cded4 into master Jan 14, 2019

8 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: publish Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@archmoj archmoj deleted the 2862-scatter3d-colorscale branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.