Display a colorscale when scatter3d.line.showscale is set #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Jan 2, 2019
src/traces/scatter3d/index.js
Outdated
| @@ -14,7 +14,11 @@ Scatter3D.plot = require('./convert'); | |||
| Scatter3D.attributes = require('./attributes'); | |||
| Scatter3D.markerSymbols = require('../../constants/gl3d_markers'); | |||
| Scatter3D.supplyDefaults = require('./defaults'); | |||
| Scatter3D.colorbar = require('../scatter/marker_colorbar'); | |||
| Scatter3D.colorbar = { | |||
| container: 'marker | line', | |||
There was a problem hiding this comment.
Hmm. That | business is a little too hacky for my taste.
Could you make this:
Scatter3D.colorbar = [{
container: 'marker',
min: 'cmin',
max: 'cmax'
}, {
container: 'line',
min: 'cmin',
max: 'cmax'
}]? Thank you!
etpinard
reviewed
Jan 2, 2019
src/components/colorbar/connect.js
Outdated
| @@ -41,19 +41,28 @@ module.exports = function connectColorbar(gd, cd, moduleOpts) { | |||
|
|
|||
| var trace = cd[0].trace; | |||
| var cbId = 'cb' + trace.uid; | |||
| var containerName = moduleOpts.container; | |||
| var container = containerName ? trace[containerName] : trace; | |||
| var containerNames = (moduleOpts.container) ? | |||
There was a problem hiding this comment.
.... and let's make this Array.isArray(moduleOpts.container) ? ....
|
Thanks for taking this one! A fairly easy new feature ripe for Could you make sure to add a test mock? |
|
💃 - let's start merging things for 1.44.0 Nice work @archmoj ! |
This was referenced Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2862
@plotly/plotly_js