Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove box ungrouping magic #3445

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Remove box ungrouping magic #3445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/traces/box/cross_trace_calc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,6 @@ function setPositionOffset(traceType, gd, boxList, posAxis) {
var boxdv = Lib.distinctVals(pointList);
var dPos0 = boxdv.minDiff / 2;

// if there's no duplication of x points,
// disable 'group' mode by setting counter to 1
if(pointList.length === boxdv.vals.length) {
fullLayout[numKey] = 1;
}

// check for forced minimum dtick
Axes.minDtick(posAxis, boxdv.minDiff, boxdv.vals[0], true);

Expand Down
Binary file added test/image/baselines/box_single-group.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
16 changes: 16 additions & 0 deletions test/image/mocks/box_single-group.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"data": [{
"type": "box",
"x0": 1,
"y": [1, 2, 1, 2, 1, 2, 3, 4, 4]
}, {
"type": "box",
"x0": 2,
"y": [2, 1, 2, 3, 3, 1, 0, 0, 1]
}],
"layout": {
"title": {"text": "single-box groups!"},
"boxmode": "group",
"showlegend": false
}
}