Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing matching axes #3506

Merged
merged 23 commits into from
Feb 18, 2019
Merged

Implementing matching axes #3506

merged 23 commits into from
Feb 18, 2019

Commits on Feb 1, 2019

  1. mv handleConstraintDefaults into constraints.js file

    @etpinard
    etpinard committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    6813865 View commit details
    Browse the repository at this point in the history

  2. first cut at static ax.matches behavior

    @etpinard
    etpinard committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    6f2bb78 View commit details
    Browse the repository at this point in the history

  3. some linting & commenting in dragbox.js

    @etpinard
    etpinard committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    5ddbf2a View commit details
    Browse the repository at this point in the history

  4. first cut at zoom/pan/scroll ax.matches behavior

    @etpinard
    etpinard committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    c60424b View commit details
    Browse the repository at this point in the history

  5. add doScroll wrapper for dragbox tests

    @etpinard
    etpinard committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    13007e0 View commit details
    Browse the repository at this point in the history

  6. mv dragbox tests calling makePlot to own describe block

    @etpinard
    etpinard committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    e962e96 View commit details
    Browse the repository at this point in the history

  7. DRY-up drag-start/assert/drag-end tests

    @etpinard
    etpinard committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    ca1de5d View commit details
    Browse the repository at this point in the history

  8. add toBeWithinArray custom jasmine matcher

    @etpinard
    etpinard committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    3b314fe View commit details
    Browse the repository at this point in the history

  9. add mucho matching axes dragbox tests

    @etpinard
    etpinard committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    6621419 View commit details
    Browse the repository at this point in the history

  10. align autobinning of histogram traces on matching axes

    @etpinard
    etpinard committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    9118505 View commit details
    Browse the repository at this point in the history

  11. link ax._categories & ax._categoriesMap to same ref for matching axes 

    - that way, they are appends across matching axes
  and the category-to-position maps just works!
    @etpinard
    etpinard committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    d9c2d4e View commit details
    Browse the repository at this point in the history

  12. add axis.matches boolean to splom dims 

    - defaults to `false`, when set to `true`,
  the generated splom axes will match
    @etpinard
    etpinard committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    c290adf View commit details
    Browse the repository at this point in the history

  13. generalize "update matched ax rng" logic 

    ... so that it works when matching an overlaying axis
    @etpinard
    etpinard committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    ef256db View commit details
    Browse the repository at this point in the history

  14. disallow constraining AND matching range

    @etpinard
    etpinard committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    9f2fad1 View commit details
    Browse the repository at this point in the history

  15. add "matches" + "scaleanchor" mock

    @etpinard
    etpinard committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    8c09944 View commit details
    Browse the repository at this point in the history

  16. fix partial ax-range relayout calls for matching axes 

    ... moreovwe, boast relayout perf for non-autorange matching axis
    groups.
    @etpinard
    etpinard committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    c5f9e74 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. fix typo (ax.setScale has no arg)

    @etpinard
    etpinard committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    d0581e2 View commit details
    Browse the repository at this point in the history

  2. use ax._matchGroup to improve matching axes relayout perf

    @etpinard
    etpinard committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    6b34ae3 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2019

  1. allow fixedrange subplots to scaleanchor with constrain:domain 

    more info in:
#3460
    @etpinard
    etpinard committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    99a9edb View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. drop *scaleanchor* constraints for axes under *matches* constraint 

    ... for now, until we found a way to apply domain scaleanchor constraints
    on matching axes (which is theoretically possible).
    @etpinard
    etpinard committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    91431ec View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2019

  1. add safe-guard in dragbox.js

    @etpinard
    etpinard committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    70b10ff View commit details
    Browse the repository at this point in the history

  2. add info about matching axis type in attr description

    @etpinard
    etpinard committed Feb 18, 2019
    2 Configuration menu
    Copy the full SHA
    772efe5 View commit details
    Browse the repository at this point in the history

  3. fix typo

    @etpinard
    etpinard committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    1713c83 View commit details
    Browse the repository at this point in the history