Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the speed of isosurface creation #3521

Merged
merged 3 commits into from Feb 12, 2019

Conversation

Projects
None yet
2 participants
@archmoj
Copy link
Collaborator

commented Feb 7, 2019

This PR speeds up the process of calculating the normals for isosurface mesh components (slices, caps, spaceframes & surfaces) by enabling flatshading and setting lighting.facenormalsepsilon to zero as defaults for this trace type.
A comparison between the two highlights significant time reduction (more than 2 times faster).
Before
After
@plotly/plotly_js

archmoj added some commits Feb 7, 2019

make iso-surface mocks run fast
isosurface defualts to speed up normal calculations
@etpinard

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

Nicely done 💃 but let's wait until 1.44.4 is out before merging.

@etpinard

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

💃 let's start merging things for 1.45.0!

@archmoj archmoj merged commit 8098c71 into master Feb 12, 2019

8 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: publish Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@archmoj archmoj deleted the speedup-isosurface branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.