Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waterfall charts #3531

Merged
merged 78 commits into from
Mar 28, 2019
Merged

Waterfall charts #3531

merged 78 commits into from
Mar 28, 2019

Commits on Feb 10, 2019

  1. started waterfall

    @archmoj
    archmoj committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    8f89564 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2019

  1. rm traceIs waterfall as it described as bar

    @archmoj
    archmoj committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    5678653 View commit details
    Browse the repository at this point in the history

  2. isFall > isSum as we may use rise and fall for positive and negative … 

    …values
    @archmoj
    archmoj committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    cfe8eb2 View commit details
    Browse the repository at this point in the history

  3. separated calc for waterfall - pass 1

    @archmoj
    archmoj committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    dbc98b5 View commit details
    Browse the repository at this point in the history

  4. removed barnorm stack and base

    @archmoj
    archmoj committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    acc3640 View commit details
    Browse the repository at this point in the history

  5. removed more useless mocks

    @archmoj
    archmoj committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    9537ee8 View commit details
    Browse the repository at this point in the history

  6. easier to use api

    @archmoj
    archmoj committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    6be0a4a View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. new baselines

    @archmoj
    archmoj committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    d6a69f2 View commit details
    Browse the repository at this point in the history

  2. handle undefined cases in extract instructions

    @archmoj
    archmoj committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    34b6a0a View commit details
    Browse the repository at this point in the history

  3. new baselines

    @archmoj
    archmoj committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    aa58571 View commit details
    Browse the repository at this point in the history

  4. auto compute color array based on vals when array left empty

    @archmoj
    archmoj committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    6a4666a View commit details
    Browse the repository at this point in the history

  5. new baselines

    @archmoj
    archmoj committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    3fb3597 View commit details
    Browse the repository at this point in the history

  6. defualt to remove instructions from ax text

    @archmoj
    archmoj committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    dc1b420 View commit details
    Browse the repository at this point in the history

  7. only accept valid tokens

    @archmoj
    archmoj committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    f8507ce View commit details
    Browse the repository at this point in the history

  8. new baselines

    @archmoj
    archmoj committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    a875ac7 View commit details
    Browse the repository at this point in the history

  9. only run waterfalls on CI for now

    @archmoj
    archmoj committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    69956a0 View commit details
    Browse the repository at this point in the history

  10. use operators instead of instr and token

    @archmoj
    archmoj committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    82dfd18 View commit details
    Browse the repository at this point in the history

  11. handle initial values

    @archmoj
    archmoj committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    87ad17c View commit details
    Browse the repository at this point in the history

  12. correct baselines cases without an initial value

    @archmoj
    archmoj committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    b0fdced View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. refactor plot using isHorizontal and else fixup

    @archmoj
    archmoj committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    4c4c8e5 View commit details
    Browse the repository at this point in the history

  2. describe connectors

    @archmoj
    archmoj committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    c052205 View commit details
    Browse the repository at this point in the history

  3. draw connector at the end of each bar

    @archmoj
    archmoj committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    fb28e30 View commit details
    Browse the repository at this point in the history

  4. extend connectors using dtick

    @archmoj
    archmoj committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    ea4863f View commit details
    Browse the repository at this point in the history

  5. fixed shape and dist between connectors

    @archmoj
    archmoj committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    af60c1f View commit details
    Browse the repository at this point in the history

  6. new baselines

    @archmoj
    archmoj committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    1827ee6 View commit details
    Browse the repository at this point in the history

  7. revised includes

    @archmoj
    archmoj committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    89e66bb View commit details
    Browse the repository at this point in the history

  8. providing a separate array for the operators

    @archmoj
    archmoj committed Feb 13, 2019
    2 Configuration menu
    Copy the full SHA
    4383a71 View commit details
    Browse the repository at this point in the history

  9. removed last connector

    @archmoj
    archmoj committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    2454e6c View commit details
    Browse the repository at this point in the history

  10. new baselines without last connector

    @archmoj
    archmoj committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    3533448 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2019

  1. Merge branch 'master' into waterfall-new-trace_dev1

    @archmoj
    archmoj committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    cd16944 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2019

  1. consider alignment and offset group across matching axes in waterfall 

    fixup attribute role and syntax
    @archmoj
    archmoj committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    f9b36cb View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. removed few unused parameters from bar cross_trace_calc

    @archmoj
    archmoj committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    3386803 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2019

  1. inherit from bars - pass 1

    @archmoj
    archmoj committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    d1c8c48 View commit details
    Browse the repository at this point in the history

  2. rm triangles

    @archmoj
    archmoj committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    cd81dcd View commit details
    Browse the repository at this point in the history

  3. removed operator - used null magic number and added initialized attri… 

    …bute to declare the first value in cases where it present an initial value
    @archmoj
    archmoj committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    e7602e2 View commit details
    Browse the repository at this point in the history

  4. removed errorbar support

    @archmoj
    archmoj committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    d1bbae6 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. removed errorbars 

    removed colorscale
removed cliponaxis
use increasing and decreasing containers similar to marker container
replaced magic number by valuetypes i.e. relative absolute and total
waterfall legends
waterfall connector draw elements and styles
waterfall hover increasing and decreasing
improved mocks and updated baselines
    @archmoj
    archmoj committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    59ee151 View commit details
    Browse the repository at this point in the history

  2. support non-array base - waterfall tests 

    fixing tests - part 2

fixup tests
    @archmoj
    archmoj committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    d8d54cd View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. revised connector line shapes

    @archmoj
    archmoj committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    c1ed50f View commit details
    Browse the repository at this point in the history

  2. revised connectors - hover showing initial - multicategory example

    @archmoj
    archmoj committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    346c637 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. Revision based on Etienne review - pass 1 

    revert package lock
revert bar cross trace calc
revert compare pixel test
created handleText function in bar and resued in waterfall
added cliponaxis
added a mock showing waterfall with bar
added select tests
removed unused mocks and colorscale code
removed r t a shortcuts
valuetype > measure
    @archmoj
    archmoj committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    fed3c97 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. fixup attributes width offset connector lines plot and test

    @archmoj
    archmoj committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    aa8abe4 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2019

  1. arrayOk width and offset back - apply offset arrays in connector draw

    @archmoj
    archmoj committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    a05352f View commit details
    Browse the repository at this point in the history

  2. added totals container and fixed hover colors

    @archmoj
    archmoj committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    20d1cbc View commit details
    Browse the repository at this point in the history

  3. fix hover color in test

    @archmoj
    archmoj committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    692c6d4 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2019

  1. waterfallmode

    @archmoj
    archmoj committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    c0b1017 View commit details
    Browse the repository at this point in the history

  2. waterfallgap

    @archmoj
    archmoj committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    9533558 View commit details
    Browse the repository at this point in the history

  3. waterfallgroupgap

    @archmoj
    archmoj committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    2480892 View commit details
    Browse the repository at this point in the history

  4. fixup waterfall mode gap groupgap

    @archmoj
    archmoj committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    f3f7d84 View commit details
    Browse the repository at this point in the history

  5. rename inner node in <g.lines> -> <g.line> 

    - to avoid confusion between group of connector nodes and
  the inner connector nodes
    @etpinard
    etpinard committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    7e41079 View commit details
    Browse the repository at this point in the history

  6. fix cliponaxis:false for waterfall traces

    @etpinard
    etpinard committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    84e3a27 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2019

  1. always drawn waterfall trace below bar/histogram

    @etpinard
    etpinard committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    00070ba View commit details
    Browse the repository at this point in the history

  2. fixup waterfall/bar mode/gap/groupgap interplay

    @etpinard
    etpinard committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    dcab107 View commit details
    Browse the repository at this point in the history

  3. revised waterfall marker logic 

    revised hover color in jasmine test
looks like a bug in bar getTraceColor function replaced mcc > mc and mlcc > mlc
    @archmoj
    archmoj committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    d52116b View commit details
    Browse the repository at this point in the history

  4. drop steps connector mode

    @archmoj
    archmoj committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    6d37db9 View commit details
    Browse the repository at this point in the history

  5. added connector visible drop false mode

    @archmoj
    archmoj committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    fb0d7a9 View commit details
    Browse the repository at this point in the history

  6. tweak bar endpoints to adjust with connector in mode between

    @archmoj
    archmoj committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    9e941ba View commit details
    Browse the repository at this point in the history

  7. dont coerce connector if visible false

    @archmoj
    archmoj committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    2a25753 View commit details
    Browse the repository at this point in the history

  8. turn connector.(color|dash|width) into -> connector.line.(color|dash|… 

    …width)
    @archmoj
    archmoj committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    1825027 View commit details
    Browse the repository at this point in the history

  9. make restyle connector visible (true|false) work

    @archmoj
    archmoj committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    4a044e4 View commit details
    Browse the repository at this point in the history

  10. fixup restyle connector visible remove nodes

    @archmoj
    archmoj committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    c53bcce View commit details
    Browse the repository at this point in the history

  11. added connector restyle visible true false

    @archmoj
    archmoj committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    3b984ff View commit details
    Browse the repository at this point in the history

  12. no need to loop over all the traces when waterfallmode is not group

    @archmoj
    archmoj committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    6b3eeab View commit details
    Browse the repository at this point in the history

  13. make waterfall NOT a 'bar' category 

    - this was causing more issues than it solved.
    @etpinard
    etpinard committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    ce0a56a View commit details
    Browse the repository at this point in the history

  14. revamp waterfall marker style logic 

    - use (increasing|decreasing|totals).marker containers
- use calcdata[i][j].dir (like ohlc/candlestick) to determine cont
- 🔪 arraysToCalcdata, *.marker* attrs are editType:'style'
- adapt Bar.plot and Bar textPointStyle for waterfall use
- split out reusable Bar.hoverPoints logic for waterfall use
- bring some Bar methods back to `master`
    @etpinard
    etpinard committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    412bf9d View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2019

  1. 🔪 [un]selected style container for waterfall (for now) 

    - use a ohlc/candlestick approach to styling onSelect

bypass [un]selected now that it is not supported in waterfall
    @etpinard @archmoj
    etpinard authored and archmoj committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    a55777f View commit details
    Browse the repository at this point in the history

  2. do not show hover label when size===0

    @etpinard @archmoj
    etpinard authored and archmoj committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    dee39dc View commit details
    Browse the repository at this point in the history

  3. adapt waterfall legend to new *marker* styles ... 

    - add logic to not show 'totals' part in legend item
  when waterfall trace does not show totals bars

fixup bar / waterfall styles
    @etpinard @archmoj
    etpinard authored and archmoj committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    a138ebd View commit details
    Browse the repository at this point in the history

  4. fixup (from 🔪 'bar' category commit)

    @etpinard @archmoj
    etpinard authored and archmoj committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    7019a12 View commit details
    Browse the repository at this point in the history

  5. fixup waterfall mocks and baselines

    @etpinard @archmoj
    etpinard authored and archmoj committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    8bbc863 View commit details
    Browse the repository at this point in the history

  6. fixup mock list

    @etpinard @archmoj
    etpinard authored and archmoj committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    b6fdaed View commit details
    Browse the repository at this point in the history

  7. adapt failing waterfall jasmine tests

    @archmoj
    archmoj committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    cb8f1ec View commit details
    Browse the repository at this point in the history

  8. fixup waterfall bar path query

    @etpinard @archmoj
    etpinard authored and archmoj committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    1447b40 View commit details
    Browse the repository at this point in the history

  9. add a flaky flag for one test

    @archmoj
    archmoj committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    4eb5daf View commit details
    Browse the repository at this point in the history

  10. waterfall marker description - set default to between mode - added sp… 

    …anning to few mocks - updated baselines
    @archmoj
    archmoj committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    f3a071e View commit details
    Browse the repository at this point in the history

  11. fix waterfall connectors - not to draw lines between null amounts - u… 

    …sing BADNUM
    @archmoj
    archmoj committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    1721ab7 View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'origin/master' into waterfall-new-trace

    @archmoj
    archmoj committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    7655664 View commit details
    Browse the repository at this point in the history

  13. set a noCI flag for the select test

    @archmoj
    archmoj committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    1d275f5 View commit details
    Browse the repository at this point in the history