Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear selection outline during 'axrange' relayout calls #3577

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

etpinard
Copy link
Contributor

Fixing an unreported regression from some past axis-range relayout performance work.

Currently, selecting a region then clicking on the modebar zoom in/out buttons does not clear the selection outlines:

peek 2019-02-25 12-35

this PR fixes that.

cc @plotly/plotly_js and #1851 were this behaviour will be augmented.

@archmoj
Copy link
Contributor

archmoj commented Feb 25, 2019

Thanks for the fix. @etpinard Would you be interested to add this codepen to the PR description?
Nicely done. 💃

@etpinard etpinard merged commit 4ec7dd1 into master Feb 25, 2019
@etpinard etpinard deleted the clear-select-on-axrange-relayout branch February 25, 2019 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants