Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parcoords dimensions values & line coloring error with integer TypedArray #3598

Merged
merged 5 commits into from
Mar 4, 2019
Merged

Fix parcoords dimensions values & line coloring error with integer TypedArray #3598

merged 5 commits into from
Mar 4, 2019

Commits on Mar 3, 2019

  1. fix 3595 i.e. to avoid integer rounding errors in parcoords when usin… 

    …g typed arrays
    @archmoj
    archmoj committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    831ca6c View commit details
    Browse the repository at this point in the history

  2. added a jasmine test to lock 3595

    @archmoj
    archmoj committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    12baea7 View commit details
    Browse the repository at this point in the history

  3. similar fix for parcoords.dimensions.values typedArray case

    @archmoj
    archmoj committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    e8cc760 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2019

  1. moved convert typedArray logic from defaults to calc step

    @archmoj
    archmoj committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    30e2c25 View commit details
    Browse the repository at this point in the history

  2. removed isTypedArray function and reused the Lib version

    @archmoj
    archmoj committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    e577e49 View commit details
    Browse the repository at this point in the history