histogram: remove gap when barmode is relative

[antoinerg]

Fixes #3649 but I am not sure this is what @alexcjohnson had in mind!

cc @nicolaskruchten

[etpinard]

we should

delete layoutOut.barmode;

when hasBars is false, so that it doesn't pollute fullLayout.

[etpinard]

++ a jasmine test in bar_test.js plz 😏

[antoinerg]

a jasmine test that checks _fullLayout doesn't have a barmode?

[etpinard]

yeah, that and the converse. Similar to

plotly.js/test/jasmine/tests/bar_test.js

Lines 214 to 228 in ef932cf

	it('should not include alignementgroup/offsetgroup when barmode is not *group*', function() {
	var gd = {
	data: [{type: 'bar', y: [1], alignmentgroup: 'a', offsetgroup: '1'}],
	layout: {barmode: 'group'}
	};
	supplyAllDefaults(gd);
	expect(gd._fullData[0].alignmentgroup).toBe('a', 'alignementgroup');
	expect(gd._fullData[0].offsetgroup).toBe('1', 'offsetgroup');
	gd.layout.barmode = 'stack';
	supplyAllDefaults(gd);
	expect(gd._fullData[0].alignmentgroup).toBe(undefined, 'alignementgroup');
	expect(gd._fullData[0].offsetgroup).toBe(undefined, 'offsetgroup');
	});

[antoinerg]

Done in bc3890b

[alexcjohnson]

That's exactly what I had in mind, thx!

[etpinard]

Ok, let's start merging things for 1.46.0

💃 💃 💃

[nicolaskruchten]

Thanks guys!