Unhide overlapping grouped bars within trace #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- convert sieve instantiation to `new Sieve(traces, {/* */}` signature
- more readable barmode switchboard
... under barmode:'group'
archmoj
reviewed
Mar 26, 2019
|
|
||
| if(fullTrace.offset === undefined) included.push(calcTrace); | ||
| else excluded.push(calcTrace); | ||
| } |
There was a problem hiding this comment.
Could we put this logic in a function and reuse it for the case of relative below?
There was a problem hiding this comment.
I'll pass if you don't mind. That would a pretty ugly function (we would have to pass functions setGroupPositionsInGroupMode, etc) and only save a few lines.
src/traces/bar/cross_trace_calc.js
Outdated
|
|
||
| var sieve = new Sieve(calcTraces, { | ||
| separateNegativeValues: barmode === 'relative', | ||
| dontMergeOverlappingData: !(barnorm || barmode === 'stack' || barmode === 'relative') |
There was a problem hiding this comment.
The function now has a more clear interface block which is great.
Now that the keys would be presented in the .min files could we zip separateNegativeValues into e.g. separateNegVals and dontMergeOverlappingData into a short form?
|
Thanks for the review @archmoj - I'll until the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3651 - where I decided to not add another attribute as the problem described in #3651 only affects bar graphs with
barmode: 'group'. See #3651 (comment) for more on the topic.cc @plotly/plotly_js @nicolaskruchten