Ternary phase diagrams #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add one visibility toogle test - add one delete / add trace test
| @@ -319,7 +319,7 @@ function hover(gd, evt, subplot) { | |||
| }), | |||
| yaArray = subplots.map(function(spId) { | |||
| var ternary = (gd._fullLayout[spId] || {})._ternary; | |||
| if(ternary) return ternary.xaxis; | |||
| if(ternary) return ternary.yaxis; | |||
- domain[0] set to 0 means to bottom of the plot area, but svg offset are computed from the top
- make sure that len is considered 0 if a is defined but not b and c. - make sure the a, b, c are defined before trying to slice them
- scatterternary fill will be part of the next iteration
- add fall back if plot_bgcolor isn't defined
| coerce('hoverinfo', (layout._dataLength === 1) ? 'a+b+c+text' : undefined); | ||
|
|
||
| // until 'fill' and 'fillcolor' are supported | ||
| traceOut.fill = 'none'; |
There was a problem hiding this comment.
@alexcjohnson feel free to git revert this commit when you'll get to fills.
| @@ -23,6 +23,10 @@ var dragElement = require('../../components/dragelement'); | |||
|
|
|||
| var fx = module.exports = {}; | |||
|
|
|||
| // TODO remove this in version 2.0 | |||
| // copy on Fx for backward compatible | |||
| fx.unhover = dragElement.unhover; | |||
There was a problem hiding this comment.
|
💃 Let's do itttt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In brief
Add ternary subplots, plus a
scatterternarytype to put on them.Also a bunch of refactoring to make this (and future) integrations easier:
axisid,sceneid,geoidinto a singlesubplotidattribute type. Ternary subplots are managed by asubplotattribute and the next step will be to use this for 3d and geo too rather than attributes calledsceneandgeo. Potentially also for cartesian, iesubplot='x2y2'- but I'm not going to change those ones in this PR.axis.coloras an attribute that sets the default for all the other colors associated with the axis. The one kind of tricky part of this isgridcolor, which has to be lightened fromaxis.colorrelative to the background color it will appear on.graph_interactsome more, creating a newdragElementcomponent, a new cartesiandragBoxmodule, and a newsetCursorfunction in libTitles.draw, instead passing a configuration object from each caller.I still need to make some test plots, but I think this is ready for review.
Limitations
scatterternarytrace trypes.contourternarywill be in a future iteration'fill'and'fillcolor') aren't supported at the momentcc @etpinard @mdtusz @jackparmer