Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More zoomed-in box/violin hover labels fixes #3965

Merged
merged 4 commits into from
Jun 25, 2019
Merged

More zoomed-in box/violin hover labels fixes #3965

merged 4 commits into from
Jun 25, 2019

Commits on Jun 14, 2019

  1. lint: rename ax -> axKey 

    ... to not confuse 'xa' & 'ya' with ax objects
    @etpinard
    etpinard committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    0e8d53e View commit details
    Browse the repository at this point in the history

  2. fix #3962 - don't build pointgroup array using d3-data indices 

    - N.B. in the case where multiple item in a given d3-data bound
  array have identical key-function results,
  *only the first* of those items is considered. This implies that
  the `i` in e.g `selection.each(function(d, i) { })` does not
  always increment with a constant step.
    @etpinard
    etpinard committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    a4b771c View commit details
    Browse the repository at this point in the history

  3. make q1 hover label have higher "priority" than min 

    ... so that if the min and q1 overlap and have the same
    overlap key-function output, q1 will be rendered, not min
    @etpinard
    etpinard committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    1634ec8 View commit details
    Browse the repository at this point in the history

  4. add 'attr' key to box/hover pointData 

    - this makes all box/hover labels render even when their x/y
  positions overlap perfectly.
    @etpinard
    etpinard committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    ce5e5f9 View commit details
    Browse the repository at this point in the history