Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix parcoords - selecting lines outside displayed range axis #4087

Merged
merged 4 commits into from
Jul 30, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jul 29, 2019

Fixes #4086.

@plotly/plotly_js

Codepen before
Codepen after

@@ -0,0 +1,821 @@
{
"data": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which looks like:

image

currently

@etpinard
Copy link
Contributor

etpinard commented Jul 29, 2019

As discussed in a private convo:

TODO:

  • add one more jasmine test

@archmoj
Copy link
Contributor Author

archmoj commented Jul 30, 2019

As discussed in a private convo:

TODO:

  • add one more jasmine test

Done in b30f07e.

@etpinard
Copy link
Contributor

Very nicely done 💃 💃

@archmoj archmoj merged commit 30d1f85 into master Jul 30, 2019
@archmoj archmoj deleted the fix4086-parcoords-stick-range branch July 30, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parcoords constraint range is stick to axis extremes when moving beyond range
2 participants