Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial rangeslider ranges #473

Merged
merged 8 commits into from
Apr 26, 2016
Merged

Initial rangeslider ranges #473

merged 8 commits into from
Apr 26, 2016

Conversation

mdtusz
Copy link
Contributor

@mdtusz mdtusz commented Apr 25, 2016

This PR adds the ability to set the initial selection of a rangeslider using xaxis.range and the total range of the slider with xaxis.rangeslider.range.

In brief:

  • Adds range attribute to rangeslider
  • Sets smart defaults, giving priority to the xaxis.range
  • By default displays the full xaxis range using autorange values

{valType: 'number'},
{valType: 'number'}
],
description: [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cldougl wording clear enough?

@etpinard
Copy link
Contributor

Looks good. I'll merge this in to get v1.10.0 out tonight.

Can you make a quick PR tomorrow addressing my two comments above? Thanks.

@etpinard etpinard merged commit 223c43f into master Apr 26, 2016
@etpinard etpinard deleted the initial-rangeslider-range branch April 26, 2016 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants