Promises: Ensure all gd._promises
resolve before final resolve
#521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Real quick PR.
In brief: ensures that all the promises pushed into
gd._promises
are resolved before the final resolve.The call to
Lib.syncOrAsync
never completes "fast enough" to causedonePlotting
to be returned (at least, not in my semi-scientific testing) and all async things should be pushing their promises to gd._promises.