Ternary restyle fix #540
Merged
Ternary restyle fix #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdtusz
force-pushed
the
ternary-restyle-fix
branch
from
44b4e70
to
befac03
Compare
| transforms.push(point.attr('transform')); | ||
| }); | ||
|
|
||
| expect(transforms).toEqual([ |
There was a problem hiding this comment.
That's fine. But, checking the content of gd.calcdata would have sufficed.
There was a problem hiding this comment.
That's what I thought as well, but calcdata was being updated before the change, while the plot wasn't (unless I was bitten by the devtool watcher gremlin).
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ternary plots were not being restyled when
a, b, cwere updated. This remedies it in the simplest possible way.I can't think of a much better way to test this - it's not a great test, but it is better than nothing, and will still check that the plotted points have changed.