-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
number like categories respect layout.autotypenumbers
#5880
base: master
Are you sure you want to change the base?
Commits on Aug 3, 2021
-
Simply trying to force all strings to be categories
Meaning even "40" gets interpreted as the string "40", a category named "40".
Configuration menu - View commit details
-
Copy full SHA for 9caf482 - Browse repository at this point
Copy the full SHA 9caf482View commit details
Commits on Aug 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 536e6e9 - Browse repository at this point
Copy the full SHA 536e6e9View commit details
Commits on Aug 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 5fc0ade - Browse repository at this point
Copy the full SHA 5fc0adeView commit details
Commits on Aug 9, 2021
-
Numeric categories in SVG paths intepreted as indices
This is because SVG paths are always strings, so there is no practical way of indicating a number was meant and not a numeric string when specifying SVG paths (sure they could be wrapped in escaped quotes but not today). So when a number is encountered in an SVG (i.e., it is a numeric string), then it is converted to a number so that it is interpreted as an index into layout.categoriesarray.
Configuration menu - View commit details
-
Copy full SHA for 69ea57c - Browse repository at this point
Copy the full SHA 69ea57cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf90246 - Browse repository at this point
Copy the full SHA bf90246View commit details
Commits on Aug 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b60fe18 - Browse repository at this point
Copy the full SHA b60fe18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b47a05 - Browse repository at this point
Copy the full SHA 6b47a05View commit details -
we cannot cast numeric strings to numbers in getDataToPixel
This made the dragging "jump" when categories were named numeric strings as the strings were all of a sudden interpreted as indices. Lets see if we can't make the pesky shapes test pass some other way.
Configuration menu - View commit details
-
Copy full SHA for 89cbf11 - Browse repository at this point
Copy the full SHA 89cbf11View commit details -
Simplification of dataToPixel code
Unfortunately the drag bug is back...
Configuration menu - View commit details
-
Copy full SHA for b3896a2 - Browse repository at this point
Copy the full SHA b3896a2View commit details
Commits on Aug 11, 2021
-
have to make special case for category axis in shapes test
This keeps the tests passing and the correct behaviour when categories are numeric strings.
Configuration menu - View commit details
-
Copy full SHA for 8ac107a - Browse repository at this point
Copy the full SHA 8ac107aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 536e513 - Browse repository at this point
Copy the full SHA 536e513View commit details
Commits on Aug 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0b48de5 - Browse repository at this point
Copy the full SHA 0b48de5View commit details
Commits on Aug 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e9901c2 - Browse repository at this point
Copy the full SHA e9901c2View commit details
Commits on Aug 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 74631d8 - Browse repository at this point
Copy the full SHA 74631d8View commit details -
good thing there's a test for this (bad thing that that is jasmine's way of running one test)
Configuration menu - View commit details
-
Copy full SHA for e8277a9 - Browse repository at this point
Copy the full SHA e8277a9View commit details -
Added baselines for images and annotations
with numeric string categories.
Configuration menu - View commit details
-
Copy full SHA for b53aa49 - Browse repository at this point
Copy the full SHA b53aa49View commit details
Commits on Sep 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9128f4c - Browse repository at this point
Copy the full SHA 9128f4cView commit details