Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

number like categories respect layout.autotypenumbers #5880

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Commits on Aug 3, 2021

  1. Simply trying to force all strings to be categories

    Meaning even "40" gets interpreted as the string "40", a category named
    "40".
    nicholas-esterer committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    9caf482 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2021

  1. Configuration menu
    Copy the full SHA
    536e6e9 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. Configuration menu
    Copy the full SHA
    5fc0ade View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2021

  1. Numeric categories in SVG paths intepreted as indices

    This is because SVG paths are always strings, so there is no practical
    way of indicating a number was meant and not a numeric string when
    specifying SVG paths (sure they could be wrapped in escaped quotes but
    not today). So when a number is encountered in an SVG (i.e., it is a
    numeric string), then it is converted to a number so that it is
    interpreted as an index into layout.categoriesarray.
    nicholas-esterer committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    69ea57c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf90246 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. linting

    nicholas-esterer committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    b60fe18 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b47a05 View commit details
    Browse the repository at this point in the history
  3. we cannot cast numeric strings to numbers in getDataToPixel

    This made the dragging "jump" when categories were named numeric strings
    as the strings were all of a sudden interpreted as indices. Lets see if
    we can't make the pesky shapes test pass some other way.
    nicholas-esterer committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    89cbf11 View commit details
    Browse the repository at this point in the history
  4. Simplification of dataToPixel code

    Unfortunately the drag bug is back...
    nicholas-esterer committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    b3896a2 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. have to make special case for category axis in shapes test

    This keeps the tests passing and the correct behaviour when
    categories are numeric strings.
    nicholas-esterer committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    8ac107a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    536e513 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. Configuration menu
    Copy the full SHA
    0b48de5 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2021

  1. Configuration menu
    Copy the full SHA
    e9901c2 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. Configuration menu
    Copy the full SHA
    74631d8 View commit details
    Browse the repository at this point in the history
  2. removed fdescribe (!)

    good thing there's a test for this (bad thing that that is jasmine's way
    of running one test)
    nicholas-esterer committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    e8277a9 View commit details
    Browse the repository at this point in the history
  3. Added baselines for images and annotations

    with numeric string categories.
    nicholas-esterer committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    b53aa49 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. mock json linting

    nicholas-esterer committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    9128f4c View commit details
    Browse the repository at this point in the history