fix uirevision autorange bug #6046
Conversation
|
@archmoj weird flaky CI failure, have you seen this before? https://app.circleci.com/pipelines/github/plotly/plotly.js/6026/workflows/967ed402-5fa4-4798-a886-4fdc0b2ab842/jobs/141674 (and a bunch more of the same with other files) It fixed itself with the second commit so not blocking, just strange and I wanted to flag it in case this has become a common occurrence. |
| var preAuto = layoutPreGUI[head + '.autorange']; | ||
| if(preAuto || (preAuto === null && pre0 === null && pre1 === null)) { | ||
| // Only read the input layout once and stash the result, | ||
| // so we get it before we start modifying it |
There was a problem hiding this comment.
This one took me a while to figure out... thorough testing pays dividends: prior to this stashing, everything worked except react to STAY implicit, which I would have thought would be an obvious noop.
I think this could be related to jasmine containers available memory. |
|
Beautiful |
@archmoj as promised, here's my fix for the uirevision autorange issue. Unfortunately this didn't allow me to remove any of the other special handling we already had in the uirevision code for other autorange cases, so it's getting complicated. But I think the tests are fairly comprehensive.