Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not exceed global font size when heatmap textfont is set to auto #6061

Merged
merged 2 commits into from Dec 15, 2021
Merged

Do not exceed global font size when heatmap textfont is set to auto #6061

merged 2 commits into from Dec 15, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Dec 15, 2021

@plotly/plotly_js

alexcjohnson
alexcjohnson approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 I agree, this is much nicer and more consistent with other traces. At some point we may want a max font size option, but not now - we'd want that for all traces with text in a shape anyway.

@archmoj archmoj merged commit 1c0a886 into master Dec 15, 2021
@archmoj archmoj deleted the heatmap-max-font-size branch December 15, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
status: reviewable type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@archmoj @alexcjohnson