Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various missing and duplicate spaces in plot schema descriptions #6183

Merged
merged 9 commits into from May 9, 2022

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 9, 2022

Fixes #6182 | cc: @nicolaskruchten
@plotly/plotly_js

@nicolaskruchten
Copy link
Member

Ahh, very satisfying that these will be fixed soon :)

@nicolaskruchten
Copy link
Member

Ah I see that in the schema there are backticks that separate these in most cases, but then downstream the backticks are stripped (in the reference docs for example)... Some day we should standardize on the backticks/asterisks in the schema attribute descriptions :)

Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj archmoj merged commit 8c63407 into master May 9, 2022
@archmoj archmoj deleted the fix6182-schema-missing-spaces branch May 9, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing spaces in schema descriptions
4 participants