Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add si locale for Sinhala language #6238

Merged
merged 7 commits into from Jul 8, 2022

Conversation

sujithranga
Copy link
Contributor

@sujithranga sujithranga commented Jun 21, 2022

Thanks for your interest in plotly.js!

Translations:

  • Please @ mention a few other speakers of this language who can help review your translations.
    @wnilanka @dinithija
  • If you've omitted any keys from dist/translation_keys.txt - which means they will fall back on the US English text - just make a short comment about why in the PR description: the English text works fine in your language, or you would like someone else to help translating those, or whatever the reason.
    // I need to check further before translate several strings but merge this PR
  • You should only update files in lib/locales/, not those in dist/

Features, Bug fixes, and others:

Before opening a pull request, developer should:

  • provide a title and write an overview of what the PR attempts to do with a link to the issue they are trying to address.
    Added si locale
  • select the Allow edits from maintainers option (see this article for more details).

After opening a pull request, developer:

  • should create a new small markdown log file using the PR number e.g. 1010_fix.md or 1010_add.md inside draftlogs folder as described in this README, commit it and push.

@archmoj
Copy link
Contributor

archmoj commented Jun 22, 2022

Thanks for the PR.
Would you please write the title in English?

lib/locales/si.js Outdated Show resolved Hide resolved
@archmoj
Copy link
Contributor

archmoj commented Jun 22, 2022

Using non-ASCII characters in the branch name as well as commit messages may cause issues for certain developers.
I suggest you kindly open a new PR with those adjustments.
Thank you!

@sujithranga sujithranga changed the title නව භාෂා ගොනුවක් එකතු කිරීම Add si locale Jun 23, 2022
@sujithranga
Copy link
Contributor Author

Would you please write the title in English?

Using non-ASCII characters in the branch name as well as commit messages may cause issues for certain developers. I suggest you kindly open a new PR with those adjustments. Thank you!

Anyway, renamed the title and rest of things are not considerable problem :)

@wnilanka
Copy link

No incorrect strings

@dinithija
Copy link

good

@archmoj
Copy link
Contributor

archmoj commented Jul 6, 2022

  • should create a new small markdown log file using the PR number e.g. 1010_fix.md or 1010_add.md inside draftlogs folder as described in this README, commit it and push.

Above task is not completed. Would you mind creating draftlogs/6238_add.md file please?

@archmoj archmoj changed the title Add si locale Add si locale for Sinhala language Jul 6, 2022
Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Thanks @sujithranga - and thank you @wnilanka and @dinithija for reviewing 🙇

@alexcjohnson alexcjohnson merged commit a815471 into plotly:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants