add delta.prefix and delta.suffix in Indicator trace
#6246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @paulovieira, this looks great! @archmoj anything this PR needs, other than including the new attributes in a mock somewhere? Perhaps the same mock you already modified to remove faulty attributes? |
archmoj
reviewed
Jul 5, 2022
archmoj
reviewed
Jul 5, 2022
|
💃 |
kMutagene
added a commit
to plotly/Plotly.NET
that referenced
this pull request
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drawDeltaaddeddeltaSuffix/deltaPrefix, following what was done in the respective suffix/prefix fornumber(implemented indrawBignumber)drawBignumberrenamedfmttobignumberFmtfor claritytest/image/mocks/indicator_scatter.jsontest, removed some invalid properties (npm run test-mock indicator_scatternow runs successfully)Closes #4824
Replaces previous PRs: #6224 and #6225 (already closed)