Automargin zoom

[hannahker]

Fix for #5567. This is a single-line fix, although I'll admit to not 100% understanding the logic behind what this line intended to do in the first place -- I can't find any undesired implications of removing this.

[archmoj]

@hannahker FYI - your fix does not address this other case that you found here: #5567 (comment)

[hannahker]

@archmoj yes, I did realize... there seem to be two (potentially related) issues:

1. in some cases the margin isn't big enough to avoid overlap with an axis title
2. zooming in to the plot causes an incorrect redraw of the axis title

Do you think it's worth addressing both here?

[hannahker]

Ah I think 1) is happening when the size of the plot can't be shrunk anymore because because it's reached the default minreducedwidth of 64px. The only thing I can think of here would be to reduce the default to something smaller.

[archmoj]

Do you think it's worth addressing both here?

No I prefer addressing different issues in different PRs. BTW the issue you mentioned is the expected behavior not a bug. So we are good here.

[alexcjohnson]

Just to note: this specific test looks fine, but only because:
(1) all the tick labels are essentially the same length. select(...).node() gives you only the first element, but the first one is unlikely to conflict with the axis title. Only the labels that are directly above the title can push it down.
(2) the tick labels are dense enough that even when you zoom in the title never fits between them. If that's not the case, when the title lines up right it can actually squeeze up between those labels.

[alexcjohnson]

💃 Very nice - good find, excellent test!