-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scattermapbox
update bug
#6387
Conversation
} | ||
|
||
function remove(noSource) { | ||
if(hadCluster) removeCluster(noSource); else removeNonCluster(noSource); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a big deal, but if you really want this to be a one-liner you can collapse it more; otherwise I'd write it as multiple lines. (same in add
below)
if(hadCluster) removeCluster(noSource); else removeNonCluster(noSource); | |
(hadCluster ? removeCluster : removeNonCluster)(noSource); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whew, looks like a lot of detailed testing went into figuring out all those conditions! Looks good - as discussed we should make a test before you lose track of what was done here, but if you want to publish the patch now and you're confident in your manual testing, feel free to go ahead with it! 💃
Thanks for the fix, folks. |
@araichev Dash 2.7.1, released Monday, includes this fix. But in general, if there's a feature or fix in plotly.js that's been released but not included in Dash yet, you can grab the plotly.js bundle (or even build your own bundle, to get unreleased features or a slimmed-down bundle size) and put it in the Or include a plotly.js CDN link in |
Fix #6382
@plotly/plotly_js