Add labelalias to various axes

[archmoj]

@plotly/plotly_js

[alexcjohnson]

💃 Great to see how compact the code change is! After considering my comment https://github.com/plotly/plotly.js/pull/6481/files#r1115892864 this looks ready to me 🚀

[archmoj]

There might be some limitations related to inherited object keys e.g. __proto__.
@alexcjohnson do you we should test for something like this?

{
    "constructor": "my constructor",
    "hasOwnProperty": "my hasOwnProperty",
    "isPrototypeOf": "my isPrototypeOf",
    "propertyIsEnumerable": "my propertyIsEnumerable",
    "toLocaleString": "my toLocaleString",
    "toString": "my toString",
    "valueOf": "my valueOf",
    "__defineGetter__": "my __defineGetter__",
    "__defineSetter__": "my __defineSetter__",
    "__lookupGetter__": "my __lookupGetter__",
    "__lookupSetter__": "my __lookupSetter__",
    "__proto__": "my __proto__",
    "get __proto__": "my get __proto__",
    "set __proto__": "my set __proto__"
}

Also there may be similar limitations in python dictionaries? cc: @nicolaskruchten

[alexcjohnson]

Oh that's a good point - I don't think any of those built-in keys will be a string unless you do something truly strange... but it wouldn't hurt to tighten up the initial condition if(ax.labelalias) into perhaps:

if(Lib.isPlainObject(ax.labelalias) && ax.labelalias.hasOwnProperty(out.text))

Or maybe even better, move the isPlainObject test into supplyDefaults (ie delete containerOut.labelalias if it's not a plain object) so we don't have to repeat that all the time.

[archmoj]

Wondering if one could possibly add $ in prefix and suffix to render every tick by mathjax?

[alexcjohnson]

Not sure why you would do that, but maybe it would work? Not particularly related to this PR though...

[archmoj]

To have dynamic mathjax labels when you zoom in & out.
Illustrated in c1d127e.

[archmoj]

Oh that's a good point - I don't think any of those built-in keys will be a string unless you do something truly strange... but it wouldn't hurt to tighten up the initial condition if(ax.labelalias) into perhaps:

if(Lib.isPlainObject(ax.labelalias) && ax.labelalias.hasOwnProperty(out.text))

Or maybe even better, move the isPlainObject test into supplyDefaults (ie delete containerOut.labelalias if it's not a plain object) so we don't have to repeat that all the time.

Addressed by 428096e.

[alexcjohnson]

🌟 💃