Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Only add minimum margin-spacing for container referenced components #6616

Merged
merged 9 commits into from
Jun 1, 2023

Conversation

hannahker
Copy link
Contributor

@hannahker hannahker commented May 29, 2023

Minor fix to #6593 and #6589:

  • Only add reservedMargin when autoexpand=true.
  • Only add the minimum reservedMargin amount, accounting for potential margin spacing added manually by the developer.

Desired behaviour is demoed in the div3 example in this CodePen: https://codepen.io/hannahker/pen/wvEZZvN

@hannahker hannahker added the bug something broken label May 29, 2023
@archmoj
Copy link
Contributor

archmoj commented May 29, 2023

@hannahker Thanks for the PR.
Please pull origin/master and merge master into this branch so that the tests work.

src/plots/plots.js Outdated Show resolved Hide resolved
src/plots/plots.js Outdated Show resolved Hide resolved
src/plots/plots.js Outdated Show resolved Hide resolved
@archmoj
Copy link
Contributor

archmoj commented Jun 1, 2023

💃

@archmoj archmoj merged commit 7829f2f into master Jun 1, 2023
1 check passed
@archmoj archmoj deleted the bugfix/container-ref-margin branch June 1, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants