Fix layout images add / remove #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that multiple images can share the same source field
|
I think there are a few more issue with |
| function keyFunction(d) { | ||
| return d.source; | ||
| function keyFunction(d, i) { | ||
| return d.source + i; |
There was a problem hiding this comment.
@mdtusz does this look right?
There was a problem hiding this comment.
or maybe we give all _isLinkedToArray (e.g. annotations, shapes, image, mapbox layers) containers a uid?
There was a problem hiding this comment.
I think this should be sufficient.
|
💃 |
|
Ok. I'll merge this in for Combining |
|
Hi guys, seems like the bug has been resolved? Will I need to download v1.14.0 now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #670
@mdtusz on
masterwe can have multiple images of the same source on a given graph.