Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hide compilation errors #6739

Merged
merged 2 commits into from Oct 4, 2023
Merged

Don't hide compilation errors #6739

merged 2 commits into from Oct 4, 2023

Conversation

dmt0
Copy link
Contributor

@dmt0 dmt0 commented Sep 30, 2023

Some compilation errors get hidden and "success" message gets shown even though the build failed.

@archmoj
Copy link
Contributor

archmoj commented Oct 4, 2023

💃

@archmoj archmoj merged commit 724bab1 into plotly:master Oct 4, 2023
1 check passed
@dmt0 dmt0 deleted the dont-hide-errors branch October 4, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants