Do not break if mouse moves to x=0 when using rangeslider #6780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
reviewed
Nov 10, 2023
archmoj
reviewed
Nov 10, 2023
archmoj
reviewed
Nov 10, 2023
|
LGTM. |
alexcjohnson
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
💃 Great find and fix @david-bezero!
FWIW we haven’t used it yet since we were stuck in ES5 until recently, but we could do this with the nullish coalescing operator
|
I considered the nullish coalescing operator and searched through the code to see if you were using it, but found no occurrences so assumed it wasn't something that can be used in this codebase. Good to know it's now something you're happy to use though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small issue: "Cannot read properties of undefined (reading '0')" if the user moves their mouse to x=0 when dragging the rangeslider. I searched through the rest of the code and this seems to be the only place with the issue.