Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tickmode "proportional" #6827

Open
wants to merge 38 commits into
base: master
Choose a base branch
from

Commits on Dec 26, 2023

  1. Add/calc tickmode "proportional" in cartesian/

    - Create tickmode "proportional"
    - Map fractional tickvals to axis values w/ axis range:
      - Set ax.(minor?).tickvals to
      - Do that right before `arrayTicks()` is called
    - Every instance of `tickmode === "array"` gets `...|| "proportional"`
    
    This works well since tickmode "proportional" really just adds a preprocess step to
    tickmode "array".
    
    TODO:
    
    - Check if graph is reversed
    - Find where ticks are redrawn on zoom and make redraw proportional (will probably fix below)
    - Figure out why ticks not redrawn on double click/home
    - Add docs in layout
    ayjayt committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    e7a2ffa View commit details
    Browse the repository at this point in the history
  2. Fix bug by which tickvals forever expands

    The algo has to set the tickvals property back to original value after
    spoofing it. This does that.
    ayjayt committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    6d48a3b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    00e884a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    931199e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fced9ce View commit details
    Browse the repository at this point in the history
  6. Remove console debug messages

    ayjayt committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    b2abf08 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    910163e View commit details
    Browse the repository at this point in the history
  8. Fix linter errors

    ayjayt committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    e21af96 View commit details
    Browse the repository at this point in the history
  9. update plot-scheme diff

    ayjayt committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    ddfaad7 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Restore proportional array later in loop:

    Plotly does some math on the ticks, sometimes comrparing major and minor
    values, so we have to store both in their own separate values and then
    restore them to their attribute at the very end so plotly has them
    throughout the calculating process.
    ayjayt committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    d42dd73 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. Configuration menu
    Copy the full SHA
    5d7b1b9 View commit details
    Browse the repository at this point in the history
  2. Add parameterized tests:

    These tests currently fail but this commit currently doesn't include
    fundamental bug fixes.
    ayjayt committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    db1f82e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a2ac023 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1fedfc7 View commit details
    Browse the repository at this point in the history
  5. Fix a bit more lint

    ayjayt committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    e8f2052 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Configuration menu
    Copy the full SHA
    c3f590d View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Configuration menu
    Copy the full SHA
    7e93370 View commit details
    Browse the repository at this point in the history
  2. Add tickmode 'full domain'

    ayjayt committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    afba178 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aca7a92 View commit details
    Browse the repository at this point in the history
  4. Fix various errata/typos

    ayjayt committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    195dfa5 View commit details
    Browse the repository at this point in the history
  5. Add test for full-domain

    ayjayt committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    a788ccc View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Configuration menu
    Copy the full SHA
    ecffc49 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Configuration menu
    Copy the full SHA
    3089c4a View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Intermediate commit w/ partial work- new strat:

    So, parameterization is good in testing.
    
    Promises + Jasmine + Karma w/o let or const make it hard to do manually.
    
    There should be a parameterization library.
    
    There is a way to make it all work (moving all loops outside of
    it/describe).
    
    Which is good, because then each parameter can be reported as a separate test,
    which improves reporting. But that solution is generally unpopular.
    ayjayt committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    99d336a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4476d38 View commit details
    Browse the repository at this point in the history
  3. Revert branch to equal master

    ayjayt committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    3502d49 View commit details
    Browse the repository at this point in the history
  4. Lint and refactor

    ayjayt committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    09ebcfc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3fe254b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    eb82723 View commit details
    Browse the repository at this point in the history
  7. update git-scheme diff

    ayjayt committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    fe6f8d0 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Configuration menu
    Copy the full SHA
    b3956a0 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Configuration menu
    Copy the full SHA
    7176049 View commit details
    Browse the repository at this point in the history
  2. Refactor as to not override ax.tickvals:

    - Use private ax._mappedTickvals instead
    - Remove use of Lib.nestedProperty during refactor
    ayjayt committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    15387ed View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2ab0b41 View commit details
    Browse the repository at this point in the history
  4. Lint

    ayjayt committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    f1a4db8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ee17af2 View commit details
    Browse the repository at this point in the history
  6. Refix incorrect patch ee17af2

    ayjayt committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    93e4bb8 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    61efdef View commit details
    Browse the repository at this point in the history