Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for xref/yref paper for shapes with layer "between" #6989

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Add support for xref/yref paper for shapes with layer "between" #6989

wants to merge 22 commits into from

Commits on Apr 30, 2024

  1. shape.layer = "between": Add support for xref/yref paper 

    Previously, it fell back to "below" for paper refs
    @my-tien
    my-tien committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6aa17d5 View commit details
    Browse the repository at this point in the history

  2. Don't draw cartesianLayerBelow in rangesliders.

    @my-tien
    my-tien committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6722977 View commit details
    Browse the repository at this point in the history

  3. Add draftlog for PR 6989

    @my-tien
    my-tien committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    822a89e View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Indicate imageLayerBetween and shapeLayerBetween as private by prepen… 

    …ding underscore
    @my-tien
    my-tien committed May 1, 2024
    Configuration menu
    Copy the full SHA
    eea649f View commit details
    Browse the repository at this point in the history

  2. Fix clear after large splom graph

    @my-tien
    my-tien committed May 1, 2024
    Configuration menu
    Copy the full SHA
    6414991 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Update baseline shapes_layer_below_traces

    @my-tien
    my-tien committed May 2, 2024
    Configuration menu
    Copy the full SHA
    cd3c002 View commit details
    Browse the repository at this point in the history

  2. don't change cartesian layer CSS class name

    @my-tien
    my-tien committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8c7c92b View commit details
    Browse the repository at this point in the history

  3. don't change xy CSS class name

    @my-tien
    my-tien committed May 2, 2024
    Configuration menu
    Copy the full SHA
    bf1167d View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Adjust number of sublots in plot_interact_test 

    there are now always 2 cartesian subplots where there was 1 before (one for background and one for foreground)
    @my-tien
    my-tien committed May 3, 2024
    Configuration menu
    Copy the full SHA
    d5d0d34 View commit details
    Browse the repository at this point in the history

  2. Update cartesian_tests

    @my-tien
    my-tien committed May 3, 2024
    Configuration menu
    Copy the full SHA
    0a1a5a3 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. splom_test: Remove test that ensures that xaxislayer-above comes afte… 

    …r gridlayer

Gridlayer is now in cartesianlayer-below, so it is below xaxislayer-above anyways.
    @my-tien
    my-tien committed May 4, 2024
    Configuration menu
    Copy the full SHA
    5514c8c View commit details
    Browse the repository at this point in the history

  2. splom_test: update test on how many inner nodes are expected in carte… 

    …sian subplots
    @my-tien
    my-tien committed May 4, 2024
    Configuration menu
    Copy the full SHA
    5cd2fec View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Add comment explaining why rangeslider's plotinfo has plotgroup: [und… 

    …efined, plotgroup]
    @my-tien
    my-tien committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ae69416 View commit details
    Browse the repository at this point in the history

  2. reverse for loop for clearing <g subplot> in cartesian plot.

    @my-tien
    my-tien committed May 10, 2024
    Configuration menu
    Copy the full SHA
    bad1bcf View commit details
    Browse the repository at this point in the history

  3. plot_interact_test: replace countSubplots with countSubplotsBackgroun… 

    …d and countSublotsForeground
    @my-tien
    my-tien committed May 10, 2024
    Configuration menu
    Copy the full SHA
    b9ec442 View commit details
    Browse the repository at this point in the history

  4. Revert changes to shapes_layer_below_traces and move those changes in… 

    …to a new mock
    @my-tien
    my-tien committed May 10, 2024
    Configuration menu
    Copy the full SHA
    dcc77e5 View commit details
    Browse the repository at this point in the history

  5. Fix for loop start index for clearing subplots

    @my-tien
    my-tien committed May 10, 2024
    Configuration menu
    Copy the full SHA
    21c3ea3 View commit details
    Browse the repository at this point in the history

  6. Add baseline image for mock zz_shapes_layer_between_xref_paper

    @my-tien
    my-tien committed May 10, 2024
    Configuration menu
    Copy the full SHA
    6c2164a View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Merge remote-tracking branch 'origin-plotly/master' into shapes_paper… 

    …_layer_between
    @my-tien
    my-tien committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    1e3c760 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Merge remote-tracking branch 'origin-plotly/master' into shapes_paper… 

    …_layer_between
    @my-tien
    my-tien committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    313480d View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Merge branch 'master' into shapes_paper_layer_between 

    Conflicts:
    src/plot_api/subroutines.js
    src/plots/cartesian/index.js
    test/jasmine/tests/splom_test.js
    @my-tien
    my-tien committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    4e0d697 View commit details
    Browse the repository at this point in the history

  2. Update leftover property name _cartesianlayer -> _cartesianlayerAbove

    @my-tien
    my-tien committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    cb495d3 View commit details
    Browse the repository at this point in the history