New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature separatethousands #848
Conversation
Great PR. Thanks! At first, I thought having Some tests are failing due to the rather strict It would be nice to add an image test for |
@@ -43,6 +43,7 @@ module.exports = function handleTickLabelDefaults(containerIn, containerOut, coe | |||
if(!tickFormat && axType !== 'date') { | |||
coerce('showexponent', showAttrDflt); | |||
coerce('exponentformat'); | |||
coerce('separatethousands'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lib.coerce
fails if a passed prop (here separatethousands
) isn't part of the attribute object used to defined the coerce
wrapper function above.
So, we need to make sure that separatethousands
is part of all attribute objects that pass through here. I believe this mean adding seperatethousands
in:
- colorbar attributes,
- gl3d axis attributes, and
- ternary axis attributes
Moreover, to enable seperatethousands
in color bars, you'll need to pass to the mock axis here.
todo
|
All done!
|
@satotake amazing PR. Thanks very much for your efforts. 🍻 |
related #841
(codepen example)[http://codepen.io/satotake/pen/wWRpbd]
It seems inconsistent that 4-digit numbers on axes such as
3000
has no comma separation while more than 5-digit numbers are separated with commas.This PR fix this issue.
If explicit flag
separatethousands
givien to layouts, 4-digit integers are applied to comma separation.Please review it.
Maybe additional tests are required...