Improve gl2d interactions #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to ensure that the reset-axes and autoscale mode bar buttons works as desired.
- as it is now called in the convert step - no duplication
| @@ -336,10 +335,11 @@ proto.plot = function(fullData, calcData, fullLayout) { | |||
| var glplot = this.glplot, | |||
| pixelRatio = this.pixelRatio; | |||
|
|
|||
| var i, j, trace; | |||
| var i; | |||
There was a problem hiding this comment.
Minor grievance 🐄 - move this closer down to where it's used.
|
💃 after the airing of 🐄 grievances. |
This was referenced Aug 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #830 and #545
In brief
heatmapglandcontourgltraces rescale properly when click on the reset axes and autoscale modebar button via 330c5f3