Fix mapbox visible false first draw #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this handles the case where a 'visible: false' are passed in during the first plot call (the restyle case worked and works fine) - note 'that visible: false' traces do not get fullTrace._module during supply defaults.
| @@ -212,7 +212,7 @@ proto.updateData = function(calcData) { | |||
| traceObj = traceHash[trace.uid]; | |||
|
|
|||
| if(traceObj) traceObj.update(calcTrace); | |||
| else { | |||
| else if(trace._module) { | |||
There was a problem hiding this comment.
Note that visible: false traces do not get fullTrace._module during supply defaults.
|
💃 These are perfect lil breaks while my tests run! |
etpinard
added a commit
that referenced
this pull request
Sep 8, 2016
Fix mapbox visible false first draw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing in
scattermapboxtrace withvisible: falsetoPlotly.plotresulted in plot code exceptions (updates withvisible: falseworked and work fine).