Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cartesian subplot updates using data joins #946

Merged
merged 17 commits into from
Oct 6, 2016
Merged

Cartesian subplot updates using data joins #946

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c877c27
move subplot creation from makePlotFramework -> Cartesian.plot
etpinard Sep 15, 2016
ff26691
rm some early-Plotly.plot logic regarding makePlotFramwork
etpinard Sep 15, 2016
40fc7f9
plots: add linkSubplot method
etpinard Sep 15, 2016
652b905
first try at making the new cartesian subplot paradigm work
etpinard Sep 15, 2016
e85a6c7
keep ref to subplot image/shape layers in main drawData
etpinard Sep 15, 2016
43d227a
lint
etpinard Sep 16, 2016
937c54b
add baseModule drawFramework step
etpinard Sep 16, 2016
78faa3f
plots: add a cartesian subplot purge step
etpinard Sep 16, 2016
f8017f2
test: adapt relinkPrivateKeys test
etpinard Sep 16, 2016
c239602
test: adapt legend scroll test
etpinard Sep 16, 2016
f4aee1e
test: adapt gd._ keys ordering
etpinard Sep 16, 2016
ab96422
test: check clip path & dragger counts in cartesian plots
etpinard Sep 16, 2016
8c09af2
Merge branch 'master' into cartesian-per-subplot
etpinard Sep 16, 2016
b00d716
Merge branch 'master' into cartesian-per-subplot
etpinard Oct 4, 2016
ae3ab55
replace plotinfo.x() -> plotinfo.xaxis
etpinard Sep 23, 2016
a708381
make makeSubplotLayer agnostic to fullLayout
etpinard Oct 5, 2016
e78b099
rm useless return in makePlotFramework
etpinard Oct 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/jasmine/tests/plots_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ describe('Test Plots', function() {
}];

var oldFullLayout = {
_plots: { xy: {} },
_plots: { xy: { plot: {} } },
xaxis: { c2p: function() {} },
yaxis: { _m: 20 },
scene: { _scene: {} },
Expand Down Expand Up @@ -54,7 +54,7 @@ describe('Test Plots', function() {
expect(gd._fullData[1].z).toBe(newData[1].z);
expect(gd._fullData[1]._empties).toBe(oldFullData[1]._empties);
expect(gd._fullLayout.scene._scene).toBe(oldFullLayout.scene._scene);
expect(gd._fullLayout._plots).toBe(oldFullLayout._plots);
expect(gd._fullLayout._plots.plot).toBe(oldFullLayout._plots.plot);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_plots is no longer relinked in Plots.supplyDefaults as

newFullLayout._plots = oldFullLayout._plots

but as

    var oldSubplots = oldFullLayout._plots || {},
        newSubplots = newFullLayout._plots = {};

    var ids = Plotly.Axes.getSubplots(mockGd);

    for(var i = 0; i < ids.length; i++) {
        var id = ids[i],
            oldSubplot = oldSubplots[id],
            plotinfo;

        if(oldSubplot) {
            plotinfo = newSubplots[id] = oldSubplot;
        }
        else {
            plotinfo = newSubplots[id] = {};
            plotinfo.id = id;
        }

        plotinfo.x = getAxisFunc(id, 'x');
        plotinfo.y = getAxisFunc(id, 'y');
        plotinfo.xaxis = plotinfo.x();
        plotinfo.yaxis = plotinfo.y();
    }

cc @rreusser

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it looks like it reconstructs a new _plots object with the same contents vs. just transferring it? Is that what makes the join work correctly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like it reconstructs a new _plots object with the same contents vs. just transferring it?

Correct. Thanks for the headsup. Maybe we could do better.

Is that what makes the join work correctly?

I don't think reconstructing _plots is necessary to make the joins work correctly.

expect(gd._fullLayout.annotations[0]._min).toBe(oldFullLayout.annotations[0]._min);
expect(gd._fullLayout.annotations[1]._max).toBe(oldFullLayout.annotations[1]._max);
expect(gd._fullLayout.someFunc).toBe(oldFullLayout.someFunc);
Expand Down