Multiple scatter plot fixes #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- by moving the line data.join out of the hasLines block
- by moving the marker and text data.joins out of the hasMarkers / hasText switch board
- now works as intended for <text> nodes
- so that <text> are properly translate on range relayout calls
rreusser
approved these changes
Sep 21, 2016
|
|
||
| join.each(function(d) { | ||
| var sel = d3.select(this).select('text'); | ||
| Drawing.translatePoint(d, sel, xa, ya); |
There was a problem hiding this comment.
A small thing but should or could we enable transitions here? I can imagine it being a matter of just following the fancy d3 transitions-work-like-everything-else pattern that the points follow. I left this out previously (though it had other update problems.)
There was a problem hiding this comment.
That will be for a future minor version bump (ref #933 (comment))
|
|
||
| function assertScatterModeSizes(lineSize, pointSize, textSize) { | ||
| var gd3 = d3.select(gd), | ||
| lines = gd3.selectAll('g.scatter.trace .js-line'), |
There was a problem hiding this comment.
Nice. Yeah. I was debating adding a bunch of d3 tests since technically it's testing internal behavior that's subject to change without affecting the look of the plots. But realistically, I think this is best.
|
I say 💃🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #952
but also I noticed that
Plotly.restyle(gd, 'mode', '')is broken onmasterfor scatter traces (since PR #802). I think I got all the cases fixed on this branch.@rreusser