Fix facet_col and animation_frame in px.imshow for xarrays. #4331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
Comment on lines
9
to
10
| - Fixed issue with px.imshow failing when facet_col is an earlier dimension than animation_frame for xarrays [[#4330](https://github.com/plotly/plotly.py/issues/4330)] | ||
| - Fixed issue with px.imshow failing when facet_col has string coordinates in xarrays [[#4329](https://github.com/plotly/plotly.py/issues/4329)] |
There was a problem hiding this comment.
Would you create a new ## UNRELEASED section above ## [5.16.1] and move these there? They can also be combined and reference the PR, something like "Fixed two issues with px.imshow: [#4330], facet_col is an earlier dimension than animation_frame for xarrays, and [#4329], facet_col has string coordinates in xarrays [#4331]"
alexcjohnson
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
💃 excellent fix @Karl-Krauth - and beautiful tests! Just a tweak to the changelog and we'll be good to merge 🥇
|
Done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request addressing #4329 and #4330.
Code PR
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).