Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build+docs: use Python 3.11 and pin a recent version of pytest #4605

Merged
merged 1 commit into from
May 13, 2024
Merged

build+docs: use Python 3.11 and pin a recent version of pytest #4605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [5.23.0] - TBD

### Updated
- Specify Python version 3.8-3.11 for development virtual environments and pin `pytest` at version 8.1.1 to match.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LiamConnors which version we used for the last plotly.py release?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also wondering perhaps we wanna mention the version in release docs below? https://github.com/plotly/plotly.py/blob/master/release.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release build uses 3.9 and the docs build also currently uses 3.9, though I have a PR to upgrade the docs build to 3.10

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://docs.python.org/3/whatsnew/3.11.html
3.11 seems to run faster when compared to 3.10.

Do you think we could/should upgrade those to 3.10 or 3.11?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you like me to check that the newly-pinned version of pytest (8.1.1) works with Python 3.9 and Python 3.10 as well as Python 3.11? contributing.md explicitly mentions Python 3.6 and Python 3.9 in conjunction with tox, which I haven't been using so far, but I could set that up and test it later today or tomorrow. RSVP.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be great.
Yeah, I guess the tox stuff is potentially out of date now. I haven't tried those steps https://github.com/plotly/plotly.py/blob/master/contributing.md#running-tests-with-tox but I'll try with a few different Python versions.

## [5.22.0] - 2024-05-01

### Updated
Expand Down
7 changes: 5 additions & 2 deletions contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,16 @@ learn and become confident about git, like http://try.github.io/.

### Create a virtual environment for plotly development

You can use either [conda][conda-env] or [virtualenv][virtualenv] to create a virtual environment for plotly development, e.g.
You can use either [conda][conda-env] or [virtualenv][virtualenv] to create a virtual environment for plotly development, e.g.:

```bash
conda create -n plotly-dev python
conda create -n plotly-dev python=3.11
conda activate plotly-dev
```

As of May 2024 our dependencies have been tested against Python versions 3.8 to 3.11.
We will support Python 3.12 and higher versions soon.

[conda-env]: https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html#creating-an-environment-with-commands
[virtualenv]: http://docs.python-guide.org/en/latest/dev/virtualenvs/

Expand Down
2 changes: 1 addition & 1 deletion packages/python/plotly/optional-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ numpy
## testing dependencies ##
coverage==4.3.1
mock==2.0.0
pytest==3.5.1
pytest==8.1.1
backports.tempfile==1.0
xarray
pytz
Expand Down