Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript typings #39

Open
ryanberckmans opened this issue Nov 4, 2019 · 6 comments
Open

Add TypeScript typings #39

ryanberckmans opened this issue Nov 4, 2019 · 6 comments

Comments

@ryanberckmans
Copy link

ryanberckmans commented Nov 4, 2019

Could you please add TypeScript typings to this repo or to a new @types/react-cytoscapejs package?

Looks like someone already wrote them https://github.com/manuc66/react-cytoscapejs-typescript-sample/blob/master/typings/react-cytoscapejs.d.ts

@PeterJFerrarotto
Copy link

That typing set is not good enough - it doesn't contain the typing details for CytoscapeComponent.normalizeElements, so the user can't call the function when using TypeScript

@manuc66
Copy link

manuc66 commented Nov 28, 2019

CytoscapeComponent.normalizeElements and other properties are now present in the definition, see: https://github.com/manuc66/react-cytoscapejs-typescript-sample/blob/master/typings/react-cytoscapejs.d.ts

@maxkfranz
Copy link
Collaborator

@manuc66, would you please add your definition to DefinitelyTyped?

There are instructions here: https://definitelytyped.org/guides/contributing.html

@manuc66
Copy link

manuc66 commented Jun 18, 2020

Here is the PR : DefinitelyTyped/DefinitelyTyped#45577

@manuc66
Copy link

manuc66 commented Jun 23, 2020

The PR has been merged

@manuc66
Copy link

manuc66 commented Feb 26, 2021

#close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants