Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop fields from one axis to another will duplicate them in React 18 #150

Closed
ianldgs opened this issue Jun 30, 2022 · 6 comments
Closed

Comments

@ianldgs
Copy link

ianldgs commented Jun 30, 2022

Screen.Recording.2022-06-30.at.10.02.04.mov

We are willing to send a PR to fix this, as we are heavy users of this library at IMC.
It's likely a bug with an older version of react-sortablejs or react-draggable.

Would anyone be able to review it? Haven't seen anyone responding to issues lately.

@bell-ho
Copy link

bell-ho commented Aug 22, 2022

I have the same problem, have you solved it?

@ianldgs
Copy link
Author

ianldgs commented Aug 22, 2022

Yes. I rewrote the drag and drop logic with dnd-kit.

Since I got no response about someone being able to review it, I just cloned it and published to our private npm repo.

@ianldgs
Copy link
Author

ianldgs commented Aug 25, 2022

@bell-ho I don't think it's rude, no. But I have to check with the legal dept of the company, don't wanna get in trouble 😄
We also have plans to open source this kind of stuff, so I think it will be fine, but will get back to you.

@bell-ho
Copy link

bell-ho commented Sep 2, 2022

@ianldgs Thank you for your consideration. I'll try customizing it until I get an answer.

@ianldgs
Copy link
Author

ianldgs commented Nov 25, 2022

I've published a package with the fixes: https://www.npmjs.com/package/@imc-trading/react-pivottable

For now, we don't have a github repo, because it's published from our internal monorepo.
But you can inspect the output on one of the following websites:

@ianldgs ianldgs closed this as completed Nov 25, 2022
@bell-ho
Copy link

bell-ho commented Nov 27, 2022

@ianldgs Thank you very much. It will be applied to the project. It's been such a big help. Thank you again.

akx added a commit to koodiklinikka/palkkakysely that referenced this issue Sep 28, 2023
akx added a commit to koodiklinikka/palkkakysely that referenced this issue Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants