Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fillable candlestick. #226

Closed
wants to merge 1 commit into from

Conversation

attila-kun
Copy link

This PR allows filling the inside area of candlesticks:

stock

@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #226 (d86b26b) into master (96d5184) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   68.83%   68.65%   -0.19%     
==========================================
  Files          56       56              
  Lines        4313     4300      -13     
==========================================
- Hits         2969     2952      -17     
- Misses       1344     1348       +4     
Impacted Files Coverage Δ
src/element/candlestick.rs 0.00% <0.00%> (ø)
src/chart/axes3d.rs 55.78% <0.00%> (-3.16%) ⬇️
src/coord/ranged3d/projection.rs 73.86% <0.00%> (-1.14%) ⬇️
src/chart/series.rs 61.70% <0.00%> (-1.07%) ⬇️
src/chart/mesh.rs 34.78% <0.00%> (-0.97%) ⬇️
src/chart/context.rs 82.83% <0.00%> (-0.47%) ⬇️
src/coord/ranged1d/types/numeric.rs 86.08% <0.00%> (-0.12%) ⬇️
src/data/float.rs 93.75% <0.00%> (-0.10%) ⬇️
src/drawing/area.rs 93.00% <0.00%> (-0.08%) ⬇️
src/coord/ranged1d/combinators/logarithmic.rs 61.45% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96d5184...d86b26b. Read the comment docs.

@inconspicuous99
Copy link

what happened to this one?

@facorread
Copy link
Member

@inconspicuous99 This PR failed both checks; the project has implemented new checks since.

Would you like to propose an updated PR and some tests? The project would appreciate it.

@38
Copy link
Member

38 commented Jul 4, 2022

Seems we already have merged a PR that fix the bug that candlestick element discard the filled field from the style.

See b41b5a7

Plus this change just make the Candlestick::new doesn't compatible with previous version, thus it's a breaking change. So I am prefer the fix I linked above.

Thanks for your contribution and please don't mind I close the PR.

@38 38 closed this Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants