Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rect bottom right edges #378

Merged
merged 5 commits into from
Jun 27, 2022

Conversation

shinmili
Copy link
Contributor

Close #368.

@38
Copy link
Member

38 commented Jun 25, 2022

Thanks for the PR, I think this make a lot of sense to me!

But again, IMO it's not a really a solution but a mitigation - And I am looking forward we can reach the point that we define a sound and uniformed backend abstraction at some point.

The change itself looks good to me!

I am wondering if @facorread and @AaronErhardt have any comment on the PR.

@facorread
Copy link
Member

I agree! I know it can be frustrating that a project chooses a long-term abstraction over a short-term solution, but the discussion here highlights the need for it. Let us try to build it!

Copy link
Member

@AaronErhardt AaronErhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@facorread facorread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nitpick of course, can you please address the warning below? It looks like removing one line should do it. Thanks!

@shinmili
Copy link
Contributor Author

shinmili commented Jun 26, 2022

@facorread Thanks for pointing out. The warning indicates the test below is actually not run on GitHub Actions, so I edited the test command line to make it run, instead of removing the line with warning.

@38 38 requested a review from facorread June 26, 2022 17:22
@38 38 merged commit 35b2060 into plotters-rs:master Jun 27, 2022
@shinmili shinmili deleted the fix-rect-bottom-right-edges branch June 28, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] DrawingArea::fill doesn't fill the right and bottom edge in some backends
4 participants