Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x_label_style, y_label_style options #78

Merged
merged 1 commit into from
Nov 2, 2019

Conversation

zhiburt
Copy link
Contributor

@zhiburt zhiburt commented Nov 2, 2019

Hey.
The code change looks straightforward.

To verify that nothing is broken followed CONTIBUTING.md guid.

  • Tests passed
  • Examples checked

It closes #52

@codecov
Copy link

codecov bot commented Nov 2, 2019

Codecov Report

Merging #78 into master will decrease coverage by 0.13%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   51.06%   50.92%   -0.14%     
==========================================
  Files          46       46              
  Lines        3915     3929      +14     
==========================================
+ Hits         1999     2001       +2     
- Misses       1916     1928      +12
Impacted Files Coverage Δ
src/chart/context.rs 80.39% <100%> (ø) ⬆️
src/chart/mesh.rs 33.16% <20%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966253a...8f5c1dc. Read the comment docs.

38 added a commit that referenced this pull request Nov 2, 2019
@38 38 merged commit 8f5c1dc into plotters-rs:master Nov 2, 2019
@38
Copy link
Member

38 commented Nov 2, 2019

Great work! This looks great to me and already merged to master.
Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Different styles for x/y labels
2 participants