Add support for fetching project's resources by namespace. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gitlab use URL-escaped `/' for API to fetch project related
resources by its namespace, so it's looks like:
namespace%2Fproject-name
The problem is Go's `http.NewRequest` use `url.Parse`
which in turn unescape the `%2F' automatically.
The only way to keep the escaped char is to use Opaque params at URL
as noted at: http://golang.org/pkg/net/url/#URL
Here is the first attempt to work-around the limitation,
we introduces another version of `ResourceUrl` and `buildAndExecRequest`
each called `ResourceUrlRaw` and `buildAndExecRequestRaw`, respectively.
`ResourceUrlRaw` will returns concatenated url and the opaque params, and
`buildAndExecRequestRaw` may accept opaque params in addition of url.
buildAndExecRequestRaw
fudanchii
added a commit
to fudanchii/drone
that referenced
this pull request
Apr 4, 2014
… import path. At least until plouc/go-gitlab-client#8 accepted or Drone officially fork it to `drone/go-gitlab` or when we have package management which can do something like this: gom 'github.com/plouc/go-gitlab-client', :github => 'fudanchii/go-gitlab-client', :branch => 'raw-request'
|
👍 |
plouc
added a commit
that referenced
this pull request
Apr 9, 2014
Add support for fetching project's resources by namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add support for parsing hook payload.