Makes all components support jobs that are currently building - from initial work by macklinu #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…initial work by macklinu
…initial work by macklinu
| @@ -35,7 +35,7 @@ class JobBuildsHistogram extends Component { | |||
| const data = builds.map(build => ({ | |||
| x: build.number, | |||
| y: build.duration / 1000 / 60, // converts ms to mn | |||
| result: build.result ? build.result.toLowerCase() : 'unkown' | |||
| result: build.result ? build.result.toLowerCase() : 'unknown' | |||
There was a problem hiding this comment.
Not sure what helper you mean? I was just fixing the typo in the existing code.
There was a problem hiding this comment.
Oh, if you mean from util.js...that is because build.result will be undefined so it won't hit the .toLowerCase() method that causes the failure.
|
I have tested the components against building jobs and the app will now rotate through dashboards successfully. Can this be merged? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.