Skip to content

Commit

Permalink
feat(axes): move all grid & axes stuff from core
Browse files Browse the repository at this point in the history
  • Loading branch information
Raphaël Benitte authored and Raphaël Benitte committed Apr 17, 2019
1 parent aa07469 commit 0b56414
Show file tree
Hide file tree
Showing 38 changed files with 870 additions and 2,306 deletions.
15 changes: 12 additions & 3 deletions packages/axes/src/canvas.js
Expand Up @@ -7,7 +7,7 @@
* file that was distributed with this source code.
*/
import { degreesToRadians } from './utils'
import { computeCartesianTicks, getFormatter } from './compute'
import { computeCartesianTicks, getFormatter, computeGridLines } from './compute'

export const renderAxisToCanvas = (
ctx,
Expand Down Expand Up @@ -112,7 +112,6 @@ export const renderAxisToCanvas = (
}
}

ctx.save()
ctx.translate(legendX, legendY)
ctx.rotate(degreesToRadians(legendRotation))
ctx.font = `${
Expand All @@ -122,7 +121,6 @@ export const renderAxisToCanvas = (
ctx.textAlign = textAlign
ctx.textBaseline = 'middle'
ctx.fillText(legend, 0, 0)
ctx.restore()
}

ctx.restore()
Expand Down Expand Up @@ -171,3 +169,14 @@ export const renderAxesToCanvas = (
})
})
}

export const renderGridLinesToCanvas = (ctx, { width, height, scale, axis, values }) => {
const lines = computeGridLines({ width, height, scale, axis, values })

lines.forEach(line => {
ctx.beginPath()
ctx.moveTo(line.x1, line.y1)
ctx.lineTo(line.x2, line.y2)
ctx.stroke()
})
}
2 changes: 1 addition & 1 deletion packages/axes/src/components/Axis.js
Expand Up @@ -6,7 +6,7 @@
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
import React, { Component, Fragment } from 'react'
import React, { Fragment } from 'react'
import PropTypes from 'prop-types'
import compose from 'recompose/compose'
import withPropsOnChange from 'recompose/withPropsOnChange'
Expand Down
Expand Up @@ -9,10 +9,9 @@
import React from 'react'
import PropTypes from 'prop-types'
import pure from 'recompose/pure'
import { defaultMotionDamping, defaultMotionStiffness } from '../../defaults'
import { motionPropTypes } from '@nivo/core'
import GridLines from './GridLines'
import { computeGridLines } from '../../lib/cartesian/axes'
import { motionPropTypes } from '../../props'
import { computeGridLines } from '../compute'

const Grid = ({
width,
Expand Down Expand Up @@ -93,15 +92,9 @@ Grid.propTypes = {

theme: PropTypes.object.isRequired,

// motion
...motionPropTypes,
}

Grid.defaultProps = {
// motion
animate: true,
motionStiffness: defaultMotionStiffness,
motionDamping: defaultMotionDamping,
}
Grid.defaultProps = {}

export default pure(Grid)
File renamed without changes.
File renamed without changes.
30 changes: 30 additions & 0 deletions packages/axes/src/compute.js
Expand Up @@ -121,3 +121,33 @@ export const getFormatter = (format, scale) => {

return d3Format(format)
}

export const computeGridLines = ({ width, height, scale, axis, values: _values }) => {
const lineValues = isArray(_values) ? _values : undefined
const lineCount = isNumber(_values) ? _values : undefined

const values = lineValues || getScaleTicks(scale, lineCount)

const position = scale.bandwidth ? centerScale(scale) : scale

let lines
if (axis === 'x') {
lines = values.map(v => ({
key: `${v}`,
x1: position(v),
x2: position(v),
y1: 0,
y2: height,
}))
} else if (axis === 'y') {
lines = values.map(v => ({
key: `${v}`,
x1: 0,
x2: width,
y1: position(v),
y2: position(v),
}))
}

return lines
}
1 change: 1 addition & 0 deletions packages/axes/src/index.js
Expand Up @@ -8,5 +8,6 @@
*/
export { default as Axes } from './components/Axes'
export { default as Axis } from './components/Axis'
export { default as Grid } from './components/Grid'
export * from './canvas'
export * from './props'
2 changes: 2 additions & 0 deletions packages/axes/tests/.eslintrc.yml
@@ -0,0 +1,2 @@
env:
jest: true

0 comments on commit 0b56414

Please sign in to comment.