feat(scales): exclude null and undefined values in log scale validati…

…on (#1099) * Exclude null and undefined in log scale validation * Fixed formatting Co-authored-by: Thomas Flanitzer <thomas.flanitzer@zuehlke.com>
plouc · Nov 11, 2020 · c87eba7 · c87eba7
1 parent 8451c27
commit c87eba7
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/packages/scales/src/logScale.js b/packages/scales/src/logScale.js
@@ -16,14 +16,16 @@ export const logScale = ({ axis, base = 10, min = 'auto', max = 'auto' }, xy, wi
     const hasZero = values.all.some(v => v === 0)
     let sign
     let hasMixedSign = false
-    values.all.forEach(v => {
-        if (hasMixedSign === true) return
-        if (sign === undefined) {
-            sign = Math.sign(v)
-        } else if (Math.sign(v) !== sign) {
-            hasMixedSign = true
-        }
-    })
+    values.all
+        .filter(v => v != null)
+        .forEach(v => {
+            if (hasMixedSign === true) return
+            if (sign === undefined) {
+                sign = Math.sign(v)
+            } else if (Math.sign(v) !== sign) {
+                hasMixedSign = true
+            }
+        })
 
     if (hasZero || hasMixedSign) {
         throw new Error(