fix(bar): avoid to redefine react forwardRef type #1793
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid to redefine react type ;)
The previous definition was problematic when using proptypes in a typescript file:
Any typescript codebase importing
@nivo/bar
suddendly can't attachpropTypes
to the returned value offorwardRef
because they are now just a function and not aForwardRefExoticComponent
anymore... unexpected & very disturbing.This resulted in breaking build with typescript errors!
The symptomatic error is ts(2339):