feat(*): Add Rubocop for Rspec

.rubocop.yml

@@ -1,3 +1,5 @@
+require: rubocop-rspec
+
 Layout/EmptyLinesAroundAttributeAccessor:
   Enabled: true
 

spec/shoulda/matchers/active_model/require_a_valid_domain_name_matcher_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Shoulda::Matchers::ActiveModel::RequireAValidDomainNameMatcher do
+  let(:server) { Server.new }
+
+  it 'accepts on domain_name' do
+    expect(server).to require_a_valid_domain_name(:domain_name)
+  end
+
+  it 'accepts without a specified attribute' do
+    expect(server).to require_a_valid_domain_name
+  end
+
+  it 'rejects on host_name' do
+    expect(server).not_to require_a_valid_domain_name(:host_name)
+  end
+
+  it 'has a description message' do
+    expect(require_a_valid_domain_name.description).to eq('require domain_name to be a valid domain name')
+  end
+end

spec/shoulda/matchers/active_model/require_a_valid_host_name_matcher_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Shoulda::Matchers::ActiveModel::RequireAValidHostNameMatcher do
+  let(:server) { Server.new }
+
+  it 'accepts on host_name' do
+    expect(server).to require_a_valid_host_name(:host_name)
+  end
+
+  it 'accepts without a specified attribute' do
+    expect(server).to require_a_valid_host_name
+  end
+
+  it 'rejects on domain_name' do
+    expect(server).not_to require_a_valid_host_name(:domain_name)
+  end
+
+  it 'has a description message' do
+    expect(require_a_valid_host_name.description).to eq('require host_name to be a valid host name')
+  end
+end

spec/shoulda/matchers/active_model/require_a_valid_ip_matcher_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Shoulda::Matchers::ActiveModel::RequireAValidIpMatcher do
+  let(:server) { Server.new }
+
+  it 'accepts on ip' do
+    expect(server).to require_a_valid_ip(:ip)
+  end
+
+  it 'accepts without a specified attribute' do
+    expect(server).to require_a_valid_ip
+  end
+
+  it 'rejects on domain_name' do
+    expect(server).not_to require_a_valid_ip(:domain_name)
+  end
+
+  it 'has a description message' do
+    expect(require_a_valid_ip.description).to eq('require ip to be a valid ip')
+  end
+end

spec/shoulda/matchers/active_model/require_a_valid_subnet_matcher_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Shoulda::Matchers::ActiveModel::RequireAValidSubnetMatcher do
+  let(:subnet) { Subnet.new }
+
+  it 'accepts on value' do
+    expect(subnet).to require_a_valid_subnet(:value)
+  end
+
+  it 'accepts without a specified attribute' do
+    expect(subnet).to require_a_valid_subnet
+  end
+
+  it 'rejects on id' do
+    expect(subnet).not_to require_a_valid_subnet(:id)
+  end
+
+  it 'has a description message' do
+    expect(require_a_valid_subnet.description).to eq('require value to be a valid subnet')
+  end
+end

spec/validates_host/domain_name_validator_spec.rb

@@ -3,38 +3,39 @@
 require 'spec_helper'
 
 describe DomainNameValidator do
+  let(:server) { Server.new }
+
   context 'when domain_name is invalid' do
-    before :each do
-      @server = Server.new(domain_name: 'http://')
+    before do
+      server.domain_name = 'http://'
+      server.valid?
     end
 
-    it 'should set object as invalid' do
-      expect(@server.valid?).to be_falsey
+    it 'sets object as invalid' do
+      expect(server).not_to be_valid
     end
 
-    it 'should set an error' do
-      @server.valid?
-      expect(@server.errors[:domain_name]).to eq(['is invalid'])
+    it 'sets an error' do
+      expect(server.errors[:domain_name]).to eq(['is invalid'])
     end
   end
 
   context 'when domain_name is valid' do
-    before :each do
-      @server = Server.new(domain_name: 'example.com')
+    before do
+      server.domain_name = 'example.com'
+      server.valid?
     end
 
-    it 'should set object as valid' do
-      expect(@server.valid?).to be_truthy
+    it 'sets object as valid' do
+      expect(server).to be_valid
     end
 
-    it 'should not set an error on attribute' do
-      @server.valid?
-      expect(@server.errors[:domain_name]).to be_blank
+    it 'does not set an error on attribute' do
+      expect(server.errors[:domain_name]).to be_blank
     end
   end
 
-  it 'should be valid with a nil value' do
-    @server = Server.new(domain_name: nil)
-    expect(@server.valid?).to be_truthy
+  it 'is valid with a nil value' do
+    expect(server).to be_valid
   end
 end

spec/validates_host/host_name_validator_spec.rb

@@ -3,38 +3,39 @@
 require 'spec_helper'
 
 describe HostNameValidator do
+  let(:server) { Server.new }
+
   context 'when host_name is invalid' do
-    before :each do
-      @server = Server.new(host_name: 'http://')
+    before do
+      server.host_name = 'http://'
+      server.valid?
     end
 
-    it 'should set object as invalid' do
-      expect(@server.valid?).to be_falsey
+    it 'sets object as invalid' do
+      expect(server).not_to be_valid
     end
 
-    it 'should set an error' do
-      @server.valid?
-      expect(@server.errors[:host_name]).to eq(['is invalid'])
+    it 'sets an error' do
+      expect(server.errors[:host_name]).to eq(['is invalid'])
     end
   end
 
   context 'when host_name is valid' do
-    before :each do
-      @server = Server.new(host_name: 'bd01')
+    before do
+      server.host_name = 'bd01'
+      server.valid?
     end
 
-    it 'should set object as valid' do
-      expect(@server.valid?).to be_truthy
+    it 'sets object as valid' do
+      expect(server).to be_valid
     end
 
-    it 'should not set an error on attribute' do
-      @server.valid?
-      expect(@server.errors[:host_name]).to be_blank
+    it 'does not set an error on attribute' do
+      expect(server.errors[:host_name]).to be_blank
     end
   end
 
-  it 'should be valid with a nil value' do
-    @server = Server.new(host_name: nil)
-    expect(@server.valid?).to be_truthy
+  it 'is valid with a nil value' do
+    expect(server).to be_valid
   end
 end

spec/validates_host/ip_validator_spec.rb

@@ -3,38 +3,39 @@
 require 'spec_helper'
 
 describe IpValidator do
+  let(:server) { Server.new }
+
   context 'when ip is invalid' do
-    before :each do
-      @server = Server.new(ip: '127.0.0')
+    before do
+      server.ip = '127.0.0'
+      server.valid?
     end
 
-    it 'should set object as invalid' do
-      expect(@server.valid?).to be_falsey
+    it 'sets object as invalid' do
+      expect(server).not_to be_valid
     end
 
-    it 'should set an error' do
-      @server.valid?
-      expect(@server.errors[:ip]).to eq(['is invalid'])
+    it 'sets an error' do
+      expect(server.errors[:ip]).to eq(['is invalid'])
     end
   end
 
   context 'when ip is valid' do
-    before :each do
-      @server = Server.new(ip: '10.10.10.1')
+    before do
+      server.ip = '10.10.10.1'
+      server.valid?
     end
 
-    it 'should set object as valid' do
-      expect(@server.valid?).to be_truthy
+    it 'sets object as valid' do
+      expect(server).to be_valid
     end
 
-    it 'should not set an error on attribute' do
-      @server.valid?
-      expect(@server.errors[:ip]).to be_blank
+    it 'does not set an error on attribute' do
+      expect(server.errors[:ip]).to be_blank
     end
   end
 
-  it 'should be valid with a nil value' do
-    @server = Server.new(ip: nil)
-    expect(@server.valid?).to be_truthy
+  it 'is valid with a nil value' do
+    expect(server).to be_valid
   end
 end