Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More core shrinking #377

Closed
wants to merge 3 commits into from
Closed

More core shrinking #377

wants to merge 3 commits into from

Conversation

samth
Copy link
Sponsor Member

@samth samth commented Jun 28, 2013

To do for the whole shrinking:

  • Remove most of net.
  • Make the core not use mzscheme.
  • Test the above.
  • Move mzscheme out of the core.
  • Move much of the compiler collection out of the core.

@mflatt
Copy link
Member

mflatt commented Jun 30, 2013

Generally looks good to me.

The "windll.rkt" module has a with-output-to-file that's missing the #:exists keyword. You might want to double-check for more (that's what I usually get wrong when porting from mzscheme to racket/base), but I didn't find other cases by just looking at random files.

The Racket version number should be incremented. If I understand correctly, that's enough to avoid any compatibility issues in xform.

@rfindler
Copy link
Member

rfindler commented Jul 1, 2013

For me, the less common but far more confusing one is pretty-print =>
pretty-write. FWIW.

Robby

On Sun, Jun 30, 2013 at 6:58 PM, Matthew Flatt notifications@github.comwrote:

Generally looks good to me.

The "windll.rkt" module has a with-output-to-file that's missing the
#:exists keyword. You might want to double-check for more (that's what I
usually get wrong when porting from mzscheme to racket/base), but I
didn't find other cases by just looking at random files.

The Racket version number should be incremented. If I understand
correctly, that's enough to avoid any compatibility issues in xform.


Reply to this email directly or view it on GitHubhttps://github.com//pull/377#issuecomment-20258190
.

@samth
Copy link
Sponsor Member Author

samth commented Jul 1, 2013

@rfindler The pretty-print -> pretty-write thing is about scheme -> racket, fortunately. However, that suggests that I need to be careful about using racket/base without checking for the things different between scheme and racket.

@rfindler
Copy link
Member

rfindler commented Jul 1, 2013

Yes, it is. mzscheme is like scheme/base in this regard, however.

On Mon, Jul 1, 2013 at 8:49 AM, Sam Tobin-Hochstadt <
notifications@github.com> wrote:

@rfindler https://github.com/rfindler The pretty-print -> pretty-writething is about
scheme -> racket, fortunately. However, that suggests that I need to be
careful about using racket/base without checking for the things different
between scheme and racket.


Reply to this email directly or view it on GitHubhttps://github.com//pull/377#issuecomment-20282668
.

@samth samth closed this Jul 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants