Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct contributing part of README according to travis config #4

Merged
merged 1 commit into from Dec 1, 2013
Merged

Correct contributing part of README according to travis config #4

merged 1 commit into from Dec 1, 2013

Conversation

freemanoid
Copy link

As I can see we always need to use dummy app for testing.

We should define BUNDLE_GEMFILE env variable or set correct default gemfile path in dummy application:
replace

ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)

by

ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../../Gemfile', __FILE__)

everywhere in dummy app

As I can see we _always_ need to use dummy app for testing.
zealot128 added a commit that referenced this pull request Dec 1, 2013
Correct contributing part of README according to travis config
@zealot128 zealot128 merged commit c81b00a into pludoni:master Dec 1, 2013
@zealot128
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants